Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimate time providing unrealistic estimates #30

Closed
rjkennedy98 opened this issue Jul 15, 2016 · 3 comments
Closed

Estimate time providing unrealistic estimates #30

rjkennedy98 opened this issue Jul 15, 2016 · 3 comments

Comments

@rjkennedy98
Copy link
Collaborator

In certain cases, because of changes in URIs being processed or because of changes in server performance, CORB job is providing an inaccurate ETC.
exempli gratia:
INFO: completed 1050801/1500000, 263 tps(avg), 19 tps(cur), ETC 00:28:25, 8 active threads.

@bbandlamudi bbandlamudi self-assigned this Jul 15, 2016
@hansenmc
Copy link
Member

hansenmc commented Jul 15, 2016

Would you expect that the current tps be applied in the calculation, to provide more weight than the overall average?

For example, calculate the ETC from both the average current tps rates with the rates you provided:
(avg ETC 28 minutes + current ETC 390 minutes)/2 = more realistic ETC of 209 minutes?

@bbandlamudi
Copy link
Contributor

bbandlamudi commented Jul 15, 2016

We were thinking we add another tps to the progress message i.e., average of last 10 or 5 (can make it configurable) tps and use this for calculation. We can manage a fixed size list of last few tps and clear this list when paused. If the average current rate is 0 tps, we can just say ETC as N/A.

We see the same problem at FFM. I normally do my own estimation based on how the performance is at present (or last few). We can make it easier for our users by doing this for them.

Let us know how this sounds.

bbandlamudi added a commit that referenced this issue Jul 25, 2016
tps values instead of total average and takes pausing into account.
@bbandlamudi
Copy link
Contributor

Updated ETC logic to take last 10 (configurable through NUM-TPS-FOR-ETC option) tps estimates taken at 30sec intervals instead of total average tps from the start. The ETC will print "0:00-1 (paused)" if the job is paused and use the new tps values after the job is resumed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants