Implemented encryption support for only parts of the connection string #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
host) with in the xcc connection string. Added test cases.
Codecov Report
@@ Coverage Diff @@
## development #124 +/- ##
=================================================
- Coverage 83.55% 83.52% -0.03%
- Complexity 1282 1284 +2
=================================================
Files 45 45
Lines 4146 4170 +24
Branches 619 624 +5
=================================================
+ Hits 3464 3483 +19
- Misses 459 460 +1
- Partials 223 227 +4
Continue to review full report at Codecov.
|
hansenmc
approved these changes
Jan 26, 2020
| try { | ||
| Pattern pattern = Pattern.compile(XCC_CONNECTION_URI_PATTERN); | ||
| Matcher matcher = pattern.matcher(connectionUri); | ||
| matcher.find(); |
There was a problem hiding this comment.
No need to invoke matcher.find() if we are going to ignore it
| LOG.info("Checking if any part of the connection string are encrypted"); | ||
| String uriAfterDecrypt = connectionUri; | ||
| try { | ||
| Pattern pattern = Pattern.compile(XCC_CONNECTION_URI_PATTERN); |
There was a problem hiding this comment.
this could be moved outside of the try/catch
| password = this.decrypter.decrypt(XCC_PASSWORD, password); | ||
| host = this.decrypter.decrypt(XCC_HOSTNAME, host); | ||
| dbname = !isBlank(dbname) ? this.decrypter.decrypt(XCC_DBNAME, dbname) : null; | ||
| uriAfterDecrypt = StringUtils.getXccUri(protocol, username, password, host, port, dbname); |
- removing `this.` where not needed - moving `pattern.compile()` outside of try block - removing unnecessary `matcher.find()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Issue-123] Supporting encryption of password, username, hostname or dbname fields of the connection string. This should enable customers to keep the existing connection string, but only encrypt the password field. Also, encrypted portion can be optionally enclosed with in ENC(). Added additional test cases to AbstractManagerTest to test this new feature. I have also done some manual testing of various use cases.