Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Command-line overrides for props are not removed from ARGV #603

Closed
grtjn opened this issue Apr 26, 2016 · 1 comment
Closed

Command-line overrides for props are not removed from ARGV #603

grtjn opened this issue Apr 26, 2016 · 1 comment
Assignees
@grtjn
Labels
bug
Milestone
July 2017

Comments

@grtjn
Copy link
Contributor

grtjn commented Apr 26, 2016

util.rb, load_prop_from_args should remove args matching the --ml.xx= pattern. I was able to fix that by copying these two lines from the find_arg function, and adding those after the if a.match...:

      index = ARGV.index(a)
      ARGV.slice!(index)
@grtjn grtjn modified the milestone: July 2017 Jun 1, 2017
grtjn added a commit to grtjn/roxy that referenced this issue Jun 7, 2017
@grtjn
Fixed marklogic-community#603: consume --ml options rather than break…
17979a4 
…ing on them
@grtjn grtjn self-assigned this Jun 7, 2017
@grtjn grtjn mentioned this issue Jun 7, 2017
Merged
grtjn added a commit to grtjn/roxy that referenced this issue Jun 8, 2017
@grtjn
Fixed marklogic-community#603: consume --ml options rather than break…
f2a1b3a 
…ing on them
@grtjn grtjn mentioned this issue Jun 8, 2017
Closed
RobertSzkutak added a commit that referenced this issue Jul 28, 2017
@RobertSzkutak
Merge pull request #787 from grtjn/603-consume-ml-args
33a2b3e 
Fixed #603: consume --ml options rather than breaking on them
@RobertSzkutak
Copy link
Contributor

Fixed in dev

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@grtjn grtjn

Labels
bug
Projects
None yet
Milestone
July 2017
Development

No branches or pull requests
2 participants
@grtjn @RobertSzkutak