Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Rewriter not initialized correctly when not selecting server-version upfront #650

Closed
grtjn opened this issue Aug 23, 2016 · 3 comments
Closed

Rewriter not initialized correctly when not selecting server-version upfront #650

grtjn opened this issue Aug 23, 2016 · 3 comments
Assignees
@grtjn
Labels
bug deployer
Milestone
July 2017

Comments

@grtjn
Copy link
Contributor

grtjn commented Aug 23, 2016

If you run ml new and forget to specify server-version, Roxy will ask, but if you pick 8, it still initializes with the wrong xqy rewriter. Luckily it auto-corrects at deploy, but it does print a warning.

Minor bug..
@grtjn grtjn added the bug label Aug 23, 2016
@grtjn grtjn added this to the 1.7.4 milestone Aug 23, 2016
@dmcassel dmcassel modified the milestones: 1.7.5, 1.7.4 Oct 18, 2016
@RobertSzkutak RobertSzkutak modified the milestones: April 2017, 1.7.5 Jan 30, 2017
@RobertSzkutak RobertSzkutak modified the milestones: July 2017, April 2017 May 5, 2017
@grtjn
Copy link
Contributor Author

grtjn commented May 28, 2017

Cannot reproduce. It may have gotten wrong by hitting enter at a preceding question where it was unnecessary. That might have caused the server-version question to get kind of skipped, leaving things in a bit of an unclean state..

grtjn added a commit to grtjn/roxy that referenced this issue May 28, 2017
@grtjn
Fixed marklogic-community#650: make sure server-version gets defaulte…
d365aa7 
…d properly in all cases
@grtjn
Copy link
Contributor Author

grtjn commented May 28, 2017

server-version could go wrong in combination with no-prompt option though..

@grtjn grtjn mentioned this issue May 28, 2017
Merged
@grtjn grtjn modified the milestones: May 2017, July 2017 May 28, 2017
grtjn added a commit to grtjn/roxy that referenced this issue May 31, 2017
@grtjn
Fixed marklogic-community#650: make sure server-version gets defaulte…
31c64c2 
…d properly in all cases
@grtjn grtjn self-assigned this Jun 1, 2017
@grtjn grtjn modified the milestones: July 2017, May 2017 Jun 6, 2017
grtjn added a commit to grtjn/roxy that referenced this issue Jun 12, 2017
@grtjn
Fixed marklogic-community#650: make sure server-version gets defaulte…
1245e13 
…d properly in all cases
grtjn added a commit to grtjn/roxy that referenced this issue Jun 12, 2017
@grtjn
marklogic-community#650: default to 9, warn about untested and EOL
e6f72cc
RobertSzkutak added a commit that referenced this issue Jun 13, 2017
@RobertSzkutak
Merge pull request #769 from grtjn/650-prompt-server-version
c290907 
Fixed #650: make sure server-version gets defaulted properly in all cases
@grtjn
Copy link
Contributor Author

grtjn commented Jun 13, 2017

Fixed in DEV

@grtjn grtjn closed this as completed Jun 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@grtjn grtjn

Labels
bug deployer
Projects
None yet
Milestone
July 2017
Development

No branches or pull requests
3 participants
@grtjn @RobertSzkutak @dmcassel