Adding roxy property to ignore certain files or folders #331
Conversation
|
Have you considered keeping those outside src/? |
|
Yes, I did. |
| @@ -204,3 +204,6 @@ mlcp-vmargs=-Xmx512m | |||
| # Temporary fix to support MarkLogic 8 EA2 | |||
| # | |||
| evaler-port=7998 | |||
|
|
|||
| # folde to ignore when deploying into modules database | |||
| ignore-folders=.*/src/(node_modules|.tmp)/.* | |||
There was a problem hiding this comment.
Move this into build.sample.properties as a comment explaining how to use it. I don't think this should be the default for everyone.
|
@miguelrgonzalez I like this and think it's useful. I added some inline comments that I'd like to see fixed before we merge it. |
|
Hi Paxton, |
Conflicts: deploy/default.properties deploy/lib/server_config.rb
|
Awesome. Thanks for submitting it. |
|
+1 on this, once Paxton's comments are addressed |
|
One sec before merging. I think it would be better to push this into the dev branch. @miguelrgonzalez would it be a lot of trouble to ask you to redo your changes based on the dev branch, and do a PR against that one? |
|
Good catch, @grtjn |
|
No problem, it's just a couple of lines really. |
|
Replaced by PR #337.. |
Specially when working with node and bower there are certain folder we don't want to be deployed into the server.