This repository has been archived by the owner on Oct 5, 2020. It is now read-only.
Fixed #206: add ms visual studio flag for compiling #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Runs smooth for me on my mac (so no side-effects for other OS). Anyone care to run a test on Windows? Pref a clean one (one on which npm install was never run before).. |
grtjn
force-pushed
the
206-node-gyph-install
branch
from
46d603c to
d9c252c
Compare
|
(forgot to push a change before writing the comment) |
|
Anyone around with a Windows machine that likes to test this? |
grtjn
added a commit
that referenced
this pull request
Feb 23, 2016
Fixed #206: add ms visual studio flag for compiling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#206.
Need to run a quick test to see if npm install doesn't break on non-win. And pref someone on a clean win to check if it works..