Skip to content
This repository has been archived by the owner on Oct 5, 2020. It is now read-only.

#405: Define variables that were left undefined #406

Merged

Conversation

patrickmcelwee
Copy link
Contributor

Fixes #405

This seems to fix it ... someone who understands this better should review the code to make sure I pull the values from the right places.

@grtjn
Copy link
Contributor

grtjn commented Oct 17, 2016

I was playing around with some changes that looked roughly similar I think. I was also trying to fix the bug of this passport stuff that caused the guestaccess to fail. I have to take a closer look though, but my quick impression was that this looks sound..

@Audarth
Copy link
Contributor

Audarth commented Nov 14, 2016

I had a bug happen when I tried to update the profile of the user,

it was in line 41 of proxy.js
!req.query.uri.match('/api/users/' + req.session.user.username + '.json'))) {

looks like it actually needs to be:

!req.query.uri.match('/api/users/' + req.session.passport.user.username + '.json'))) {

@grtjn grtjn changed the title Define variables that were left undefined #405: Define variables that were left undefined Nov 15, 2016
@grtjn
Copy link
Contributor

grtjn commented Nov 15, 2016

I'll append that last change myself. Thanks for the PR and the testing!

@grtjn grtjn merged commit 3d08a87 into marklogic-community:master Nov 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reqOptions is not defined
3 participants