Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEVEXP-417 Tweaked token renewal to be based on 401 instead of 403 #1562

Merged
merged 1 commit into from
May 11, 2023
Merged

DEVEXP-417 Tweaked token renewal to be based on 401 instead of 403 #1562

merged 1 commit into from
May 11, 2023

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented May 10, 2023

No description provided.

@rjrudin rjrudin requested review from anu3990 and BillFarber May 10, 2023 18:42
BillFarber
BillFarber reviewed May 10, 2023
View reviewed changes
Copy link
Contributor

@BillFarber BillFarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but it failed checks, so not approving for now.

@rjrudin
Copy link
Contributor Author

rjrudin commented May 11, 2023

That's fine, the failures were just because of the internal devops problem yesterday with SSL.

@rjrudin rjrudin requested a review from BillFarber May 11, 2023 10:33
@rjrudin rjrudin merged commit b3c58d7 into develop May 11, 2023
@rjrudin rjrudin deleted the feature/417-cloud-401 branch May 11, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillFarber BillFarber BillFarber approved these changes

@anu3990 anu3990 Awaiting requested review from anu3990 anu3990 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjrudin @BillFarber