MLE-12345 Going back to clearing the database #1807
Conversation
Deleting each URI fails for temporal URIs. Blah.
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the database clearing logic by replacing a complex XQuery-based approach with the MarkLogic Java API's built-in delete functionality. The change addresses issues with deleting temporal URIs that were causing failures in the previous implementation.
- Replaces custom XQuery document deletion with QueryManager.delete() API
- Adds explicit wait time to handle potential forest availability issues on Jenkins
- Imports QueryManager class to support the new approach
| "return fn:count($uris)") | ||
| .evalAs(String.class); | ||
| LoggerFactory.getLogger(ConnectedRESTQA.class).info("Cleared database, deleting {} URIs", count); | ||
| try (DatabaseClient client = newDatabaseClientBuilder().withPort(port).build()) { |
There was a problem hiding this comment.
The authentication configuration (admin_user and admin_password) that was present in the original implementation has been removed. This may cause authentication failures if the database requires explicit credentials.
| // Clearing the database occasionally causes a forest to not be available for a moment or two when the tests | ||
| // are running on Jenkins. This leads to intermittent failures. Waiting is not guaranteed to avoid the | ||
| // error but simply hopes to minimize the chance of an intermittent failure. | ||
| waitFor(2000); |
There was a problem hiding this comment.
The magic number 2000 should be extracted to a named constant to improve code readability and maintainability. Consider defining a constant like FOREST_AVAILABILITY_WAIT_MS.
Deleting each URI fails for temporal URIs. Blah.