-
Notifications
You must be signed in to change notification settings - Fork 74
MLE-24505 Doing full build on PR pipeline #1837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Verifying that all code can be compiled, even when running a subset of the tests.
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Purpose: Ensure every module compiles in the PR pipeline even when only a subset of tests is executed, by adding a pre-test full build step.
- Adds a pre-test Gradle build (excluding tests) in two shell script sections.
- Introduces inline comments explaining the intent.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| export GRADLE_USER_HOME=$WORKSPACE/$GRADLE_DIR | ||
| export PATH=$GRADLE_USER_HOME:$JAVA_HOME/bin:$PATH | ||
| cd java-client-api | ||
| // Ensure all modules can be built first. |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line appears inside a shell (sh) multiline string; // is not a valid Bash comment and will be interpreted as a command (likely causing a command not found error). Replace with a Bash comment (# ...) or move the remark outside the shell string as a Groovy comment.
| // Ensure all modules can be built first. | |
| # Ensure all modules can be built first. |
| export GRADLE_USER_HOME=$WORKSPACE/$GRADLE_DIR | ||
| export PATH=$GRADLE_USER_HOME:$JAVA_HOME/bin:$PATH | ||
| cd java-client-api | ||
| // Ensure all modules can be built first. |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as earlier occurrence: // inside a shell script block is not a valid Bash comment and will be executed as a command. Use a Bash comment (# Ensure all modules...) or place the comment outside the sh string.
| // Ensure all modules can be built first. | |
| # Ensure all modules can be built first. |
| export PATH=$GRADLE_USER_HOME:$JAVA_HOME/bin:$PATH | ||
| cd java-client-api | ||
| // Ensure all modules can be built first. | ||
| ./gradlew clean build -x test |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invoking clean build -x test forces a full rebuild, then later running marklogic-client-api:test will re-execute tasks that could have been up-to-date; consider using assemble (or a narrower aggregation task) instead of build, and avoid clean unless required for correctness to reduce build time.
| ./gradlew clean build -x test | |
| ./gradlew assemble |
| export PATH=$GRADLE_USER_HOME:$JAVA_HOME/bin:$PATH | ||
| cd java-client-api | ||
| // Ensure all modules can be built first. | ||
| ./gradlew clean build -x test |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate full clean build sequence as above may add unnecessary build time; consider replacing with ./gradlew assemble (or specific compile/package tasks) and omit clean unless a known incremental build issue exists.
| ./gradlew clean build -x test | |
| ./gradlew assemble |
Verifying that all code can be compiled, even when running a subset of the tests.