Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 6, 2025

Verifying that all code can be compiled, even when running a subset of the tests.

Verifying that all code can be compiled, even when running a subset of the tests.
Copilot AI review requested due to automatic review settings October 6, 2025 18:07
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Copyright Validation Results
Total: 1 | Passed: 0 | Failed: 0 | Skipped: 1 | at: 2025-10-06 18:07:37 UTC | commit: 58432dc

⏭️ Skipped (Excluded) Files

  • Jenkinsfile

✅ All files have valid copyright headers!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Purpose: Ensure every module compiles in the PR pipeline even when only a subset of tests is executed, by adding a pre-test full build step.

  • Adds a pre-test Gradle build (excluding tests) in two shell script sections.
  • Introduces inline comments explaining the intent.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

export GRADLE_USER_HOME=$WORKSPACE/$GRADLE_DIR
export PATH=$GRADLE_USER_HOME:$JAVA_HOME/bin:$PATH
cd java-client-api
// Ensure all modules can be built first.
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line appears inside a shell (sh) multiline string; // is not a valid Bash comment and will be interpreted as a command (likely causing a command not found error). Replace with a Bash comment (# ...) or move the remark outside the shell string as a Groovy comment.

Suggested change
// Ensure all modules can be built first.
# Ensure all modules can be built first.

Copilot uses AI. Check for mistakes.
export GRADLE_USER_HOME=$WORKSPACE/$GRADLE_DIR
export PATH=$GRADLE_USER_HOME:$JAVA_HOME/bin:$PATH
cd java-client-api
// Ensure all modules can be built first.
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as earlier occurrence: // inside a shell script block is not a valid Bash comment and will be executed as a command. Use a Bash comment (# Ensure all modules...) or place the comment outside the sh string.

Suggested change
// Ensure all modules can be built first.
# Ensure all modules can be built first.

Copilot uses AI. Check for mistakes.
export PATH=$GRADLE_USER_HOME:$JAVA_HOME/bin:$PATH
cd java-client-api
// Ensure all modules can be built first.
./gradlew clean build -x test
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invoking clean build -x test forces a full rebuild, then later running marklogic-client-api:test will re-execute tasks that could have been up-to-date; consider using assemble (or a narrower aggregation task) instead of build, and avoid clean unless required for correctness to reduce build time.

Suggested change
./gradlew clean build -x test
./gradlew assemble

Copilot uses AI. Check for mistakes.
export PATH=$GRADLE_USER_HOME:$JAVA_HOME/bin:$PATH
cd java-client-api
// Ensure all modules can be built first.
./gradlew clean build -x test
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate full clean build sequence as above may add unnecessary build time; consider replacing with ./gradlew assemble (or specific compile/package tasks) and omit clean unless a known incremental build issue exists.

Suggested change
./gradlew clean build -x test
./gradlew assemble

Copilot uses AI. Check for mistakes.
@rjrudin rjrudin merged commit 1fe9b82 into develop Oct 6, 2025
3 checks passed
@rjrudin rjrudin deleted the feature/jenkins-build-all branch October 6, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants