Bugfix MLE-19691 StorageClass when leave empty not pointing to default and change the name of data director to datadir #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks like this PR contains a lot more than the title states. Please add some comments about what's actually in this PR. |
rwinieski
requested changes
Feb 5, 2025
Collaborator
rwinieski
left a comment
rwinieski
left a comment
There was a problem hiding this comment.
@pengzhouml you take the chance the change the data volume name which is good.
Could you add a relevant commit message?
Collaborator
Author
Sure. Will do that |
pengzhouml
force-pushed
the
bugfix/MLE-19691-storageClass
branch
from
a81f9d1 to
cd9f9f9
Compare
pengzhouml
changed the title
added 8 commits
February 5, 2025 17:09
pengzhouml
requested review from
barkhachoithani,
sumanthravipati and
vitalykorolev
rwinieski
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.