Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

ELS endpoints require security user connection #258

Closed
grechaw opened this issue Mar 17, 2018 · 3 comments
Closed

ELS endpoints require security user connection #258

grechaw opened this issue Mar 17, 2018 · 3 comments
Assignees
@grechaw
Milestone
3.6.2

Comments

@grechaw
Copy link
Contributor

grechaw commented Mar 17, 2018

I discovered while developing DHF deployments that there is a small bug in

ProtectedPathManager
QueryRolesetsManager

The unit tests were actually failing on a recent b9 build, so perhaps the bug is not exposed in current releases. In any event, I've got a patch, and soon a PR, that fixes the issue by overriding useSecurityConfig() in each of these two classes. I think that's the right thing to do, and the tests now pass.
@grechaw grechaw self-assigned this Mar 17, 2018
grechaw pushed a commit to grechaw/ml-app-deployer that referenced this issue Mar 17, 2018
Issue marklogic#258 use security config for query rolesets and protec…
24e9247 
…ted paths
@rjrudin
Copy link
Contributor

rjrudin commented Mar 19, 2018

Thanks @grechaw - how urgent is a fix for this? I can make an ml-app-deployer and ml-gradle 3.6.2 right now.

rjrudin added a commit that referenced this issue Mar 19, 2018
@rjrudin
Merge pull request #259 from grechaw/els-security-config
9a15bb6 
Issue #258 use security config for query rolesets and protected paths
@grechaw
Copy link
Contributor Author

grechaw commented Mar 19, 2018

A release would enable me to finish a sprint on time and finish a demo for MarkLogic World. Doing it now would exceed my wildest expectations.

rjrudin added a commit that referenced this issue Mar 19, 2018
@rjrudin
#258 Added tests for manager classes that use the security user
b5f69a1
@rjrudin rjrudin added this to the 3.6.2 milestone Mar 19, 2018
@rjrudin rjrudin closed this as completed Mar 19, 2018
@rjrudin
Copy link
Contributor

rjrudin commented Mar 19, 2018

If I only publish 3.6.2 of ml-app-deployer, is that okay? You can force ml-gradle to use a different version of ml-app-deployer

@rjrudin rjrudin modified the milestones: 3.6.2, 3.7.0 Apr 1, 2018
@rjrudin rjrudin modified the milestones: 3.7.0, 3.6.2 Apr 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@grechaw grechaw

Labels
None yet
Projects
None yet
Milestone
3.6.2
Development

No branches or pull requests
2 participants
@grechaw @rjrudin