DeployQueryRolesets uses manageClient

[grechaw]

Feel free to consider this not-a-bug if there's a good workaround.

The issue I have...
at bootstrapping time for my project all I have is admin/admin.
mlSecurityUsername=admin
mlSecurityPassword=admin

I've put my manage user and role in ml-config/security/users and /roles
with the intention that the security user creates them, and then that user can go on to deploy other things. (here's where you can say dont do that and move on if you like)

With 3.6.1, what happens during mlDeploy is:

a. query rolesets are deployed. this is done with the right credentials, but in the middle of deployment (line 75 or QueryRolesetsManager) it queries the db for role ids using manageClient.

b. the manage client has not been created yet. so I get a 401.

So either there's a sorting issue (create users before query rolesets) or QueryRolesetsManager should use the same credentials throughout, or both.

Thoughts on this @rjrudin ? I can work on fixing the issue if you give me an idea of the root cause.

[rjrudin]

I think this is simply that line 75 should use getJsonAsSecurityUser, right?

[rjrudin]

@grechaw I made the above fix, that should be all that it is. Looks like ProtectedPathManager has the same issue, so I'll fix that too.

[grechaw]

awesome, thanks Rob