Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

ml-gradle checks for RestAPI server on Default group even if server is targeted on another group. #298

Closed
gku11ava opened this issue Aug 9, 2018 · 2 comments
Assignees
Milestone

Comments

@gku11ava
Copy link

gku11ava commented Aug 9, 2018

RestApiManager.java checks for the RestAPI server on the Default group because it instantiates a default ServerManager without providing a group name.

Proposed Fix:
com.marklogic.mgmt.api.restapi RestApi.java should pass it's group variable as an argument when it instantiates an instance of the RestApiManager.

RestApiManager should have a private String variable for storing group name and include a constructor that accepts a group name argument. If no group name is provided, it remains null. When ServerManager gets created as part of the call to restApiServerExists, if group != null, the group name should be passed as an argument with the ServerManager constructor.

@rjrudin
Copy link
Contributor

rjrudin commented Aug 9, 2018

Thanks @gku11ava - how soon do you need a fix? I can toss out a 3.8.4 fairly quickly, just wondering if I should wait for any other issues to pop up, or if you'd like this ASAP (ASAP is totally fine).

@gku11ava
Copy link
Author

gku11ava commented Aug 9, 2018

@rjrudin It's not a major priority as we can workaround it by having a default group configured (even if it is empty). There doesn't seem to be a problem in subsequent deployments where the Rest API server already exists.

@rjrudin rjrudin self-assigned this Aug 11, 2018
@rjrudin rjrudin modified the milestones: 3.8., 3.8.4 Aug 11, 2018
@rjrudin rjrudin closed this as completed Aug 12, 2018
@rjrudin rjrudin modified the milestones: 3.8.4, 3.9.0 Aug 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants