This repository was archived by the owner on Sep 16, 2024. It is now read-only.
Release/4.5.3 #487
Merged
Release/4.5.3 #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for deploying databases much more quickly by getting all forest details in a single request as opposed to one request per forest via /manage/v2. Any issue results in /manage/v2 being used instead. A simple test was added for this, but the method is being tested by dozens of existing tests - i.e. any test that involves deploying a database is hitting this. There's no actual change in functionality too - it's purely a performance optimization.
There aren't any tests to add as the test cluster only has a single node. Instead doing manual testing against a 3-node cluster in Docker. The change is straightforward: if CMA is enabled, then submit a CMA config containing each of these forests with each of its replicas. If that fails, or if CMA is not enabled, then submit each forest one-by-one to /manage/v2.
Refactored the call for getting a map of forests - moved it into CommandContext so it's easier to reuse by separate commands. Note that `DeployOtherDatabasesCommand` is being reverted back as no changes are needed there anymore.
BillFarber
approved these changes
Aug 24, 2023
anu3990
approved these changes
Aug 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.