Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#636 Clarified instructions in mlNewProject #640

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Dec 19, 2022

Also bumped version to 4.4-SNAPSHOT

@rjrudin rjrudin requested a review from BillFarber December 19, 2022 17:09
@rjrudin
Copy link
Contributor Author

rjrudin commented Dec 19, 2022

@crism Thanks for the suggestion - here's what the text looks like now:

Welcome to the new project wizard. Please answer to the following prompts to start a new project.

Each prompt below begins with '[ant:input]'; type your responses on the blank line, or press 'Enter' to accept the default value or values in the brackets.

Note that this will overwrite your current build.gradle and gradle.properties files, and backup copies of each will be made.

[ant:input] Application name: [myApp]

@rjrudin rjrudin added this to the 4.4.0 milestone Dec 19, 2022
@@ -8,8 +8,10 @@ class NewProjectTask extends MarkLogicTask {

@TaskAction
void newProject() {
println "Welcome to the new project wizard. Please answer the following questions to start a new project."
println "Note that this will overwrite your current build.gradle and gradle.properties files, and backup copies of each will be made."
println "\nWelcome to the new project wizard. Please answer to the following prompts to start a new project.\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase here is awkward.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less awkward-ified.

Copy link
Contributor

@BillFarber BillFarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the phrasing needs to be fixed.

Also bumped version to 4.4-SNAPSHOT
@rjrudin rjrudin force-pushed the feature/636-mlNewProject branch from 119bdcd to 8263870 Compare December 19, 2022 18:18
@rjrudin rjrudin requested a review from BillFarber December 19, 2022 18:18
@rjrudin rjrudin merged commit 228ffc9 into dev Dec 20, 2022
@rjrudin rjrudin deleted the feature/636-mlNewProject branch December 20, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants