Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVEXP-183: Fixing bug in mlPrintForestPlan #645

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Jan 24, 2023

This was not accounting for the fact that the "deployForestsCommand" will be null when a user is explicitly creating forests instead of dynamically creating them via properties.

This was not accounting for the fact that the "deployForestsCommand" will be null when a user is explicitly creating forests instead of dynamically creating them via properties.
@rjrudin rjrudin requested review from BillFarber and peetkes January 24, 2023 17:24
@rjrudin
Copy link
Contributor Author

rjrudin commented Jan 24, 2023

@peetkes Will wait to hear from you on this, want to make sure you're good with this.

@rjrudin rjrudin merged commit 7a84956 into dev Jan 26, 2023
@rjrudin rjrudin added this to the 4.5.0 milestone Jan 26, 2023
@rjrudin rjrudin deleted the feature/183-printPlan-custom-forests branch January 26, 2023 15:47
@peetkes
Copy link
Contributor

peetkes commented Jan 30, 2023

mlPrintForestPlan runs as expected now. Thanks for fixing this @rjrudin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants