fix: properly resolve lasso manifest in hydrate output #2395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
lasso-marko
uses regularpath.resolve
instead of arequire.resolve
when processing the dependencies provided from the Marko compiler (https://github.com/lasso-js/lasso-marko/blob/9d4a2f7c190167e5bc3ab1015de54b14163e21b6/lasso-marko-plugin.js#L273).In the hydrate compilation Marko tries to shorten all import paths to trim off
node_modules
, eg./node_modules/@ebay/ebayui-core/thing
gets shortened to@ebay/ebayui-core/thing
with the assumption it will be resolved later. Howeverlasso-marko
was not resolving this, so this PR changes it such that the dependencies provided to lasso are the full (relative) posix path.Checklist: