Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: async iterator race condition #2402

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

DylanPiercey
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 3c215fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
marko Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 52.27273% with 21 lines in your changes missing coverage. Please review.

Project coverage is 87.01%. Comparing base (586d378) to head (3c215fb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/marko/src/runtime/html/AsyncStream.js 52.27% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2402      +/-   ##
==========================================
- Coverage   87.05%   87.01%   -0.05%     
==========================================
  Files         347      347              
  Lines       39232    39262      +30     
  Branches     2535     2535              
==========================================
+ Hits        34155    34162       +7     
- Misses       5048     5071      +23     
  Partials       29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 0a38845 into main Dec 12, 2024
7 of 9 checks passed
@DylanPiercey DylanPiercey deleted the fix-async-iterator-api-race-condition branch December 12, 2024 03:48
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant