Fix null check logic in JsonMapConverter.mapToJson() #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the condition from 'if (map != null)' to 'if (map == null)' to properly validate null input. The previous logic was throwing an exception when the map was valid, causing all tests to fail. Fixes #1 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
JsonMapConverter.mapToJson()methodif (map != null)toif (map == null)on line 40Problem
The method was throwing an
IllegalArgumentExceptionwhen a valid (non-null) map was passed, and would only proceed with null maps, which is the opposite of the intended behavior.Solution
Corrected the null check logic to properly validate that the input map is not null before processing.
Test Results
All tests in
JsonMapConverterTestnow pass:testMapToJson_SimpleMap()testMapToJson_NestedMap()testMapToJson_EmptyMap()testMapToJson_NullInput()testRoundTrip_JsonToMapToJson()Fixes #1
🤖 Generated with Claude Code