Fix inverted null check in mapToJson method #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #18 where tests were failing due to an inverted null check in the
mapToJsonmethod.Problem
The
mapToJsonmethod inJsonMapConverter.javahad a logic error on line 41:This condition was backwards - it was throwing an exception when the map was NOT null, instead of when it WAS null.
Impact
This bug caused 5 test failures:
testMapToJson_SimpleMap(line 78) - Failed because valid map triggered exceptiontestMapToJson_NestedMap(line 97) - Failed because valid map triggered exceptiontestMapToJson_EmptyMap(line 110) - Failed because valid empty map triggered exceptiontestMapToJson_NullInput(line 118) - Failed because null input did NOT trigger exceptiontestRoundTrip_JsonToMapToJson(line 144) - Failed because valid map triggered exceptionSolution
Changed line 41 from:
To:
This simple fix corrects the logic so that:
IllegalArgumentExceptionas expectedTesting
All 5 previously failing tests should now pass with this fix.
Fixes #18