Fix null check bug in mapToJson method #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #1 by correcting an inverted null check condition in the
mapToJsonmethod.Problem
The
mapToJsonmethod inJsonMapConverter.javahad an inverted null check on line 40:This caused the method to:
IllegalArgumentExceptionwhen the map was not null (incorrect)gson.toJson(map)(incorrect)Solution
Changed the condition to properly validate null input:
Now the method correctly:
IllegalArgumentExceptionwhen the map is null (correct)Testing
All tests in
JsonMapConverterTestshould now pass:testMapToJson_SimpleMap✅testMapToJson_NestedMap✅testMapToJson_EmptyMap✅testMapToJson_NullInput✅testRoundTrip_JsonToMapToJson✅Fixes #1