-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to discord.js@12.0.0 #61
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markokajzer
force-pushed
the
discordjs-v12
branch
2 times, most recently
from
January 22, 2020 12:22
947fab1
to
ae6e058
Compare
markokajzer
force-pushed
the
discordjs-v12
branch
from
March 3, 2020 19:51
9e15f25
to
3de9205
Compare
markokajzer
force-pushed
the
discordjs-v12
branch
2 times, most recently
from
March 3, 2020 20:01
3916882
to
ad6ccb9
Compare
markokajzer
force-pushed
the
discordjs-v12
branch
from
March 3, 2020 20:03
ad6ccb9
to
57cff37
Compare
markokajzer
force-pushed
the
discordjs-v12
branch
from
March 3, 2020 20:25
57cff37
to
b61c0ae
Compare
cc @nstapelbroek LMAO 👌 |
markokajzer
force-pushed
the
discordjs-v12
branch
from
March 3, 2020 20:32
b61c0ae
to
d0685a3
Compare
markokajzer
changed the title
Upgrade to discord.js@v12.0.0
Upgrade to discord.js@12.0.0
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done
discord.js
v12@discordjs/opus
to avoid deprecated and abandonednode-opus
package.node-version
fileHow to test
Notes
Node v12 (newest) was not possible due to a transitive dependency ofnode-opus
to a package calledref
which is incompatible with Node v12This is definitely a reason to ditchnode-opus
entirely in favor ofopusscript
opusscript
is said to be not very performant in the discord.js docs but how big is the difference? Is it really worth this whole hassle? I couldn't find any mentions of this outside of that README and it has been there since forever. Maybe the issues have been resolved?Could also tryref-napi
according to this comment