Fix -a flag and extend token lists #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BrianBohe
commented
Feb 22, 2023
BrianBohe
commented
- Set -a to match assembly names and ilproj filenames without extensions. Seems reasonable to fail if TestProjectAlias is null as it would be unmasking a problem getting the ilproj filename without extensions.
- Extends special token and typedef token list based on what is needed for tests under JIT/jit64.
BrianBohe
force-pushed
the
fix-a_and_extensions
branch
from
a987690 to
803b577
Compare
markples
changed the title
markples
reviewed
Feb 22, 2023
ILTransform/ILRewriter.cs
Outdated
| @@ -556,7 +556,7 @@ private void RewriteFile(string source) | |||
| } | |||
| } | |||
| int identEnd = charIndex; | |||
| string sourceName = Path.GetFileNameWithoutExtension(source); | |||
| TestProject.GetKeyNameRootNameAndSuffix(_testProject.TestProjectAlias, out _, out string sourceName, out _); | |||
There was a problem hiding this comment.
I think this might need to be RelativePath and not TestProjectAlias. The latter has already had GetFileNameWithoutExtension run on it, so with something like a.b.csproj, this would pull out a "second extension".
markples
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.