Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary::isEmpty() method added #43

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

Smoren
Copy link
Contributor

@Smoren Smoren commented Feb 25, 2023

Hi @markrogoyski,

I've added new methods and covered them by tests:

  • Summary::isEmpty()
  • Stream::isEmpty()

@coveralls
Copy link

coveralls commented Feb 25, 2023

Pull Request Test Coverage Report for Build 4351704604

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 99.867%

Totals Coverage Status
Change from base Build 4350957471: 0.001%
Covered Lines: 752
Relevant Lines: 753

💛 - Coveralls

@markrogoyski
Copy link
Owner

LGTM. Just a comment about some additional test cases that clarify what empty really means.

@Smoren Smoren force-pushed the summary_is_empty branch from 0e0c7c3 to 7aa6142 Compare March 7, 2023 07:22
@Smoren
Copy link
Contributor Author

Smoren commented Mar 7, 2023

Thank you @markrogoyski,

I've added the new test cases you suggested.

@markrogoyski markrogoyski merged commit e979d4d into markrogoyski:develop Mar 8, 2023
@Smoren Smoren deleted the summary_is_empty branch March 8, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants