Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set::union() method added #45

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Conversation

Smoren
Copy link
Contributor

@Smoren Smoren commented Mar 2, 2023

Hi @markrogoyski,

I've added new methods and covered them by tests:

  • Set::union()
  • Set::unionCoercive()
  • Stream::unionWith()
  • Stream::unionCoerciveWith()

@coveralls
Copy link

coveralls commented Mar 2, 2023

Pull Request Test Coverage Report for Build 4368218265

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 99.868%

Totals Coverage Status
Change from base Build 4361445493: 0.001%
Covered Lines: 758
Relevant Lines: 759

💛 - Coveralls

@Smoren
Copy link
Contributor Author

Smoren commented Mar 8, 2023

This branch is rebased from develop.

@markrogoyski
Copy link
Owner

Hi @Smoren,

Thanks for the PR. It's neat that you were able to make use of partialIntersection to implement it.

Mark

@markrogoyski markrogoyski merged commit 5778d00 into markrogoyski:develop Mar 9, 2023
@Smoren
Copy link
Contributor Author

Smoren commented Mar 9, 2023

Thank you for merging this PR!

@Smoren Smoren deleted the set_union branch March 9, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants