Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All imported logs with --date are 1 day ahead #8

Closed
robinbohnen opened this issue Dec 14, 2018 · 9 comments
Closed

All imported logs with --date are 1 day ahead #8

robinbohnen opened this issue Dec 14, 2018 · 9 comments

Comments

@robinbohnen
Copy link

When I import with this command: gw2pvo --gw-station-id --gw-account --gw-password --pvo-system-id --pvo-api-key --log debug --date 2018-12-13 --darksky-api-key

It will import the data of 2018-12-12 (at GoodWe) to 2018-12-13 (at Pvoutput).
How can I fix this?

@eNeRGy164
Copy link
Contributor

I think this is because the timezone code has been changed/removed in the latest commit?

@markruys
Copy link
Owner

Might be very well the case. The original code gave errors (cf issue #7), so we have to look into this again.

@vijghph
Copy link

vijghph commented Jan 19, 2019

I confirm the issue: the retroactive loading of data is setup day "one+1". To be fixed.

@vijghph
Copy link

vijghph commented Jan 20, 2019

I noticed the JSON response for GetPowerStationPowerAndIncomeByDay() contains a sequence of data for day-1 then the day itself. So the fix maybe actually quite simple. I'll propose it.

vijghph added a commit to vijghph/gw2pvo that referenced this issue Jan 20, 2019
It appears that GetPowerStationPowerAndIncomeByDay returns figures for multiple dates.
Hence this "fix" in order to ensure that the correct one is taken into account.
The code could probably be cleaner but knowing that it is not 100% sur how the GoodWe API works, it is robust as such.
@Koploper
Copy link

I confirm the issue also. Can the fix be added to the code?

@vijghph
Copy link

vijghph commented Mar 24, 2019

Any hope of getting a build with the proposed fix?

@daemenseth
Copy link

I can confirm the fix is working. I hope there is fast a build with the fixes

@lbbrhzn
Copy link

lbbrhzn commented Apr 5, 2019

the fix from vijghph is working for me as well.

@lbbrhzn
Copy link

lbbrhzn commented Apr 5, 2019

Unfortunately, this fix is does seem to work for the current day.

The issue appear to be that GetPowerStationPowerAndIncomeByDay does not return the running total for the current day.

However, GetPowerStationPacByDayForApp appears to have this info in the 'today_power' field. Note that it always contains the value for the current day, not for the requested day!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants