Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces bin/restart by bin/cli kill and removes sleep command #1245

Merged

Conversation

HoePe999
Copy link

As mentioned in #1189

Copy link

what-the-diff bot commented Nov 14, 2024

PR Summary

  • Update on methods to restart PHP-FPM service
    The methods xdebug_enable and xdebug_disable have been updated to use bin/cli kill -USR2 1 instead of bin/restart phpfpm for restarting the PHP-FPM service. This update should provide a more efficient method for restarting the service.

  • Removal of redundant commands
    Unnecessary sleep 1 commands, which were previously included in both xdebug_enable and xdebug_disable functions, have been removed to streamline the code. This removal leads to cleaner code with less delayed processes.

@markshust
Copy link
Owner

Thanks for this -- I'll just need to test this out, but if works fine I'll go ahead and merge it in 👍

@markshust
Copy link
Owner

This works awesome!! Thanks so much. Merging in.

@markshust markshust merged commit 0b39385 into markshust:release/next Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants