Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert times to UTC if in UTC mode #106

Merged
merged 2 commits into from
Oct 26, 2017

Conversation

hanzi
Copy link
Contributor

@hanzi hanzi commented Oct 4, 2017

By default, event times are given in UTC with the Z suffix.

Unfortunately, the suffix is added statically without actually converting the time. So if the DateTime object is not already in the UTC timezone, a wrong date will appear in the output.

This PR adds the missing conversion.

@markuspoerschke
Copy link
Owner

Looks good to me! Thanks for your contribution! :)

@markuspoerschke markuspoerschke merged commit f35c9c5 into markuspoerschke:master Oct 26, 2017
@markuspoerschke
Copy link
Owner

The change was released in 0.13.0! 🍻

@djschilling
Copy link

@markuspoerschke
Can this change be backported to the version with php 5.6 support, please?

@markuspoerschke
Copy link
Owner

@djschilling Was released in 0.11.5.

@djschilling
Copy link

Thx. Thats great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants