Add event organizer #260
Add event organizer #260
Conversation
website/docs/component-event.md
Outdated
| ### Organizer | ||
|
|
||
| The Organizer defines the person who is organizing the event. | ||
| The property consists of an email address. |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
The verb ‘recommended’ is used with the gerund form: “recommended using”. (ADMIT_ENJOY_VB[1])
Suggestions: recommended using
URL: https://www.ef.com/english-resources/english-grammar/gerund-equals-infinitive/
Rule: https://community.languagetool.org/rule/show/ADMIT_ENJOY_VB?lang=en-US&subId=1
Category: GRAMMAR
| ### Organizer | ||
|
|
||
| The Organizer defines the person who organises the event. | ||
| The property consists of at least an email address. |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
The verb ‘recommended’ is used with the gerund form: “recommended using”. (ADMIT_ENJOY_VB[1])
Suggestions: recommended using
URL: https://www.ef.com/english-resources/english-grammar/gerund-equals-infinitive/
Rule: https://community.languagetool.org/rule/show/ADMIT_ENJOY_VB?lang=en-US&subId=1
Category: GRAMMAR
|
@markuspoerschke Would it be possible to get a new version for that? :) |
|
@aarongerig Thanks for the reminder. My bot just created a new release: https://github.com/markuspoerschke/iCal/releases/tag/2.2.0 |
|
@markuspoerschke Awesome, thank you! |
|
|
||
| public function toUri(): Uri | ||
| { | ||
| return new Uri('mailto:' . urlencode($this->emailAddress)); |
There was a problem hiding this comment.
Outlook 2016 is having trouble with the encoded "@" character in the email address.
According to RFC standard, the mailto: doesn't require the url-encoding of that character. From the RFC 5545 3.8.4.3 (Organizer) section, see its examples, but it says "Value Type: CAL-ADDRESS" -> look for that in the RFC, find definition here -> says "the value must be a mailto URI, as defined by [RFC2368].", see its examples.
By RFC 2368's examples, it seems that it implies the "@" should remain unencoded. The solution then would mean parsing the email address, such as is seen in this related StackOverflow discussion on the topic: https://stackoverflow.com/questions/8940445/what-is-the-correct-way-to-escape-a-string-for-a-mailto-link
In our case, we're going to just look for %40 in the ORGANIZER property and convert it back to @, which will suffice.
Fix #252