Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add attendee #333

Merged
merged 28 commits into from
Oct 29, 2021
Merged

Feature/add attendee #333

merged 28 commits into from
Oct 29, 2021

Conversation

giorginogreg
Copy link
Contributor

As the title.
This closes issue #190

@giorginogreg
Added attendee Object
4c6af3c
@giorginogreg
Added attendee property to event
b2b058f
@giorginogreg
Added factory rules for attendees
8bad0fe
@giorginogreg
Fix bug yield
7a8faac
@giorginogreg
Fix test errors
ba1abda
@giorginogreg
Implemented rsvp parameter
2bf4eaa
@giorginogreg
Fix code
87a5f51
@giorginogreg
Fix PSAlm
30d40e1
@giorginogreg
Added Boolean value test
69d75a3
@giorginogreg
Added Calendar User Type
52d02a0
@giorginogreg
Fix CN parameter
b3592e1
@giorginogreg
Added calendar user type to parameters in event factory
a3ca547
@giorginogreg
Added vscode folder to gitignore, fix typo test class
a3dffb2
@giorginogreg
Fixed calendar user type, added test
e06314f
@giorginogreg
Add members attendee managing
dc4cdf7
@giorginogreg
Added role type to attendee
801330f
@giorginogreg
update constructor attendee, now more oop-oriented
70b54d1
@giorginogreg
Inserted delegated from property
eb13085
@giorginogreg
Added sent by param
95137d9
@giorginogreg
Added test for display name
04a39f1
@giorginogreg
Add directory Entry ref. parameter
b6c9c31
@giorginogreg
Add language parameter
3f2a173
@giorginogreg
Added documentation
e836d4d
@giorginogreg giorginogreg mentioned this pull request Oct 9, 2021
Closed
markuspoerschke
markuspoerschke requested changes Oct 11, 2021
View reviewed changes
Copy link
Owner

@markuspoerschke markuspoerschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. Please have a look at my comments.

.vscode/settings.json Outdated Show resolved Hide resolved
src/Domain/Entity/Event.php Outdated Show resolved Hide resolved
src/Presentation/Factory/EventFactory.php Outdated Show resolved Hide resolved
src/Domain/Entity/Event.php Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/Domain/Enum/CalendarUserType.php Show resolved Hide resolved
src/Domain/ValueObject/Attendee.php Outdated Show resolved Hide resolved
src/Domain/ValueObject/Member.php Outdated Show resolved Hide resolved
src/Presentation/Component/Property/Value/QuotedUriValue.php Show resolved Hide resolved
@markuspoerschke markuspoerschke enabled auto-merge (squash) October 29, 2021 21:36
@markuspoerschke
Copy link
Owner

Thanks for this feature!

@markuspoerschke markuspoerschke merged commit a5c57b2 into markuspoerschke:2.x Oct 29, 2021
@giorginogreg giorginogreg deleted the feature/add-attendee branch October 30, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuspoerschke markuspoerschke Awaiting requested review from markuspoerschke

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giorginogreg @markuspoerschke