Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow new lines in event descriptions #53

Merged

Conversation

jrjohnson
Copy link
Contributor

I'm pretty sure that description is allowed to contain new lines:
https://tools.ietf.org/html/rfc5545#page-85

I took at pass at implementing this, but I'm happy to do it a different way.

@jrjohnson
Copy link
Contributor Author

@markuspoerschke anything I need to do to get this merged? Scrutinizer just says Canceled, I don't see a way to run it again or get any error output.

@jrjohnson
Copy link
Contributor Author

@markuspoerschke friendly reminder. Can I make any changes to get this merged?

@markuspoerschke
Copy link
Owner

Hey,

thanks for your changes!

I will merge it now. Sorry for the delay!

Cheers
Markus

markuspoerschke added a commit that referenced this pull request Nov 13, 2015
Allow new lines in event descriptions
@markuspoerschke markuspoerschke merged commit 340c634 into markuspoerschke:master Nov 13, 2015
@jrjohnson
Copy link
Contributor Author

Great and thanks for the quick release as well! Love the library, saved me at least a month of work.

@jrjohnson jrjohnson deleted the newline-description branch November 14, 2015 05:21
@dlubitz
Copy link

dlubitz commented Dec 21, 2015

Hey guys. Sorry, but this PR breaks the possibility of line breaks in the description.
See RFC: http://www.ietf.org/rfc/rfc2445.txt Page 81

Example: The following is an example of the property with formatted
line breaks in the property value:

 DESCRIPTION:Meeting to provide technical review for "Phoenix"
   design.\n Happy Face Conference Room. Phoenix design team
   MUST attend this meeting.\n RSVP to team leader.

So the line breaks "\n" have to replaced with the string '\n' as it was before this change. In version 0.8.0 everything works as expected with linebreaks in the description.

@jrjohnson
Copy link
Contributor Author

@dlubitz That isn't how I read the RFC, but I'm completely willing to be wrong. I read it as "formatted
line breaks" meaning real line breaks and not line break '\n' characters in the string. Seems a bit unclear, but maybe I'm just bad at reading RFCs.

@dlubitz
Copy link

dlubitz commented Dec 21, 2015

@jrjohnson: I think the section 4.3.11 "Text" makes it more clear.

ESCAPED-CHAR = "" / ";" / "," / "\N" / "\n")
; \ encodes , \N or \n encodes newline
...

An intentional formatted text line break MUST only be included in a
"TEXT" property value by representing the line break with the
character sequence of BACKSLASH (US-ASCII decimal 92), followed by a
LATIN SMALL LETTER N (US-ASCII decimal 110) or a LATIN CAPITAL LETTER
N (US-ASCII decimal 78), that is "\n" or "\N".

buergimi added a commit to buergimi/iCal that referenced this pull request Jan 7, 2016
…description"

This reverts commit 340c634, reversing
changes made to 6ad1850.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants