-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow new lines in event descriptions #53
Allow new lines in event descriptions #53
Conversation
@markuspoerschke anything I need to do to get this merged? Scrutinizer just says Canceled, I don't see a way to run it again or get any error output. |
@markuspoerschke friendly reminder. Can I make any changes to get this merged? |
Hey, thanks for your changes! I will merge it now. Sorry for the delay! Cheers |
Allow new lines in event descriptions
Great and thanks for the quick release as well! Love the library, saved me at least a month of work. |
Hey guys. Sorry, but this PR breaks the possibility of line breaks in the description.
So the line breaks "\n" have to replaced with the string '\n' as it was before this change. In version 0.8.0 everything works as expected with linebreaks in the description. |
@dlubitz That isn't how I read the RFC, but I'm completely willing to be wrong. I read it as "formatted |
@jrjohnson: I think the section 4.3.11 "Text" makes it more clear.
|
I'm pretty sure that description is allowed to contain new lines:
https://tools.ietf.org/html/rfc5545#page-85
I took at pass at implementing this, but I'm happy to do it a different way.