Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Recurrence rule generation #560

Open
wants to merge 6 commits into
base: 2.x
Choose a base branch
from

Conversation

amnuts
Copy link

@amnuts amnuts commented Oct 8, 2023

Allows you to create recurrence rules - fixes #189.

Tests included for the components.

example4.php gives a small example of adding a recurrence rule.

@amnuts amnuts marked this pull request as ready for review October 10, 2023 21:59
@amnuts amnuts changed the title Made a start on recurrence rule generation Recurrence rule generation Oct 11, 2023
PHP 7.4 doesn't support union or mixed types.  But Psalm complains there are no types on 8.x tests.  So now where you could pass in a single value or an array of the values, you're forced to always pass in an array.
@amnuts amnuts changed the title Recurrence rule generation [FEATURE] Recurrence rule generation Oct 18, 2023
@amnuts
Copy link
Author

amnuts commented Oct 25, 2023

@markuspoerschke, any feedback on this one? Not what you were wanting? I appreciate that the hacktoberfest label was added to a ticket that was a few years old (wish I had noticed that before starting 😁), so possibly you've got some other mechanism in place that I didn't spot.

@sanderdlm
Copy link

Trying to port a 0.11.x implementation to 2.x that heavily relied on recurrence rules. Getting this merged would be sweet. Anything I could help with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement recurring events
2 participants