Add geographic position property to event #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realised that we need a new property type, since semicolons in normal strings are escaped. |
| @@ -273,6 +274,10 @@ public function buildPropertyBag() | |||
| } | |||
| } | |||
|
|
|||
| if (null != $this->locationGeo) { | |||
| $propertyBag->set('GEO', new GeoValue($this->locationGeo)); | |||
There was a problem hiding this comment.
@psztucz Why do we need a ValueObject when there is no logic at all in there?
|
Isn't that already implemented with 7a3751f? |
|
@sgehrig right. I will close this one. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that you already have geolocation in event with X-APPLE-STRUCTURED-LOCATION, however this does not work with non-apple devices. This commit simply adds RFC compliant property GEO to event(see RFC 5545)