Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make GEO property RFC 5545 compliant #74

Merged
merged 1 commit into from
Jun 9, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Eluceo/iCal/Component/Event.php
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ class Event extends Component

/**
* Dates to be excluded from a series of events.
*
*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There has been an empty space here that was being kicked by the editor on saving.

* @var \DateTime[]
*/
protected $exDates = array();
Expand Down Expand Up @@ -270,7 +270,7 @@ public function buildPropertyBag()
)
)
);
$propertyBag->set('GEO', $this->locationGeo);
$propertyBag->set('GEO', str_replace(',', ';', $this->locationGeo));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very very naively exchanging the , (that is required by the Apple geo property and therefore is required in the geo parameter as well) with a ;

}
}

Expand Down