Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for DateTimeImmutable in buildPropertyBag #99

Merged
merged 2 commits into from
Jun 5, 2017
Merged

Add support for DateTimeImmutable in buildPropertyBag #99

merged 2 commits into from
Jun 5, 2017

Commits on Jun 5, 2017

  1. Add support for DateTimeImmutable in buildPropertyBag 

    If `dtEnd` were to be a DateTimeImmutable instead of a DateTime, the add method would have no effect on the outcome.

Here, we update the stored dtEnd with the result of the add method.  For a DateTime object, this will be the same object - for a DateTimeImmutable object, this will be a new DateTimeImmutable one day in the future.
    @navarr
    navarr committed Jun 5, 2017
    Configuration menu
    Copy the full SHA
    e3210f1 View commit details
    Browse the repository at this point in the history

  2. Add test and clone dtEnd to avoid side effects

    @markuspoerschke
    markuspoerschke committed Jun 5, 2017
    Configuration menu
    Copy the full SHA
    cecf7d0 View commit details
    Browse the repository at this point in the history