Migrate CI to GitHub Actions #217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note: - numpy@1.26.4 dropped support for Python <= 3.8 - numpy@1.20+ broke mir_eval. A fix was merged in mir_eval@main but has not been released yet - see: mir-evaluation/mir_eval#352 - matplotlib@3.9.0 brakes mir_eval - see: mir-evaluation/mir_eval#383 - i updated pytest hoping it would help solve failing tests but that's a HUGE v3—>v8 jump. I only made the bare minimum of fixes to accomodate this upgrade, and I would expect more work is needed - i wanted to add python 11/12 support but delayed this until we can already get tests runnning properly on 3.9/3.10
|
Thanks for all the work on this! I'm a bit swamped over the next couple of weeks, but I'll try to pick this up. |
bmcfee
reviewed
Dec 6, 2024
| # mir_eval>=0.8 | ||
| # because numpy 1.20+ broke mir_eval 0.7 | ||
| # https://github.com/craffel/mir_eval/issues/352 | ||
| mir_eval @ git+https://github.com/craffel/mir_eval@main |
There was a problem hiding this comment.
This is a temp block, but we really shouldn't have requirements.txt at all here; dependencies should be implemented through setup.cfg
|
👋 finally got mir_eval 0.8 out the door, so this should be unblocked! (Tagging @giovana-morais ) |
|
i'm on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I understand there was interest from the maintainer in migrating CI to GitHub Actions.
Having some familiarity with GitHub Actions, and needing to get this package otherwise working with modern Python, I endeavored to give it a try.
It was more work than hoped for, and some more work is still needed to get this over the finish line.
Right now, a lot of tests are still failing but I lack the time to dig further, and am hamstrung by my near total lack of experience w/ Python.
Some notes:
numpy@1.25.0 dropped support for Python <= 3.8numpy@1.20+ brokemir_eval.mir_evalmain branch but has not been released yet.mir_evalmain branch for the time being 🫠mir_evalrelease is what we really need.matplotlib@3.9.0 brakesmir_eval.mir_evalrelease?pytesthoping it would help solve failing tests but that's a HUGE v3—>v8 jump. I only made the bare minimum of fixes to accomodate this upgrade, and I would expect more work is needed.Would anyone be willing to try and pick things up where I left them?