Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more changes to the model so that it is consistent with paper #11

Merged
merged 1 commit into from
Nov 8, 2017

Conversation

auroracramer
Copy link
Collaborator

  • Move ReLU after batch norm
  • Use weight decay (assumed L2)
  • Set learning rate to 1e-4
  • Allow for volume gain less than 0dB, as paper seems like it should allow for that

* Move ReLU _after_ batch norm
* Use weight decay (assumed L2)
* Set learning rate to 1e-4
* Allow for volume gain less than 0dB, as paper seems like it should allow for that
Copy link
Collaborator

@hohsiangwu hohsiangwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also recommend that to change all the print in the train function to be logging so it will show up while training using sbatch.

@auroracramer
Copy link
Collaborator Author

If you specify an out file in the sbatch file, it will also save stdout from the script. But it would indeed be more robust to use logging rather than print statements.

@auroracramer auroracramer merged commit c18055b into master Nov 8, 2017
@auroracramer auroracramer deleted the model-fixes branch November 8, 2017 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants