feat: Add support for Sox's compression(bitrate) argument #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @adinhodovic, the new feature looks great but from what I can see you are changing one of the dependencies from |
|
hey @lostanlen, I believe the dependency was renamed in the PyPi registry and the newer versions were only found under |
|
It would be nice to have this merged @lostanlen |
lostanlen
requested changes
May 30, 2024
sox/transform.py
Outdated
| @@ -343,6 +344,9 @@ def _validate_output_format(self, output_format): | |||
| if channels is not None and channels <= 0: | |||
| raise ValueError('channels must be a positive number') | |||
|
|
|||
| if not isinstance(bitrate, float) and bitrate is not None: | |||
| raise ValueError('bitrate must be an float or None') | |||
There was a problem hiding this comment.
grammar
must be a positive float ?
|
tests are failing on MP3 ? |
Adds support for bitrate as parameter to output arguments. It is useful converting files to MP3 format. Requires a new version of soundfile(0.11.0) that supports MP3 formats alongside upgraded libsndfile version to 1.1.0. This is for the `test_bitrate_valid` test.
adinhodovic
force-pushed
the
compression-support
branch
from
f82feb1
to
e0721a9
Compare
|
Can you re run the workflow, think the OS mp3 dependency was missing. |
|
👍 looking forward to this functionality being added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for bitrate as parameter to output arguments. It is useful converting files to MP3 format. Requires a new version of soundfile(0.11.0) that supports MP3 formats alongside upgraded libsndfile version to 1.1.0. This is for the
test_bitrate_validtest.