Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated imp #160

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Remove deprecated imp #160

merged 3 commits into from
Jan 23, 2024

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jan 5, 2024

Fixes #158.

imp is imported in docs/conf.py but not used, so we can delete it.

imp in setup.py is used to read the version from sox/version.py, so we can instead replace with the suggestion from the Python Packaging User Guide on "Single-sourcing the package version":

As of the release of setuptools 46.4.0, one can accomplish the same thing by instead placing the following in the project’s setup.cfg file (replacing “package” with the import name of the package):

[metadata]
version = attr: package.__version__

@lostanlen
Copy link
Member

i have resolved the conflicts with recently merged #161 in setup.cfg. @hugovk is this good?

@coveralls
Copy link

Coverage Status

coverage: 98.823%. remained the same
when pulling c0052cd on hugovk:replace-imp
into 5e93526 on rabitt:master.

@hugovk
Copy link
Contributor Author

hugovk commented Jan 23, 2024

All set!

@lostanlen lostanlen merged commit e99079a into marl:master Jan 23, 2024
6 checks passed
@hugovk hugovk deleted the replace-imp branch January 23, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated imp module with importlib
3 participants