Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI build for aarch64 for all platforms #67

Merged
merged 4 commits into from
Aug 25, 2022

Conversation

xEgoist
Copy link
Contributor

@xEgoist xEgoist commented Aug 23, 2022

closes #60

This change introduces the ability to build aarch64 binaries and upload the artifacts.
The CI can also be expanded to include other architectures. Sample run: here

Because it's hard to test these builds on Github Action (with the exception of running linux builds under qemu), tests were left to the x86_64 builds.

xEgoist and others added 2 commits August 23, 2022 15:42
* Added CI build for aarch64 for all patforms.
This commit resolves the problem where rosetta would cause zigup to
download x86 binaries if the x86_64 version was used.
@marler8997 marler8997 force-pushed the master branch 4 times, most recently from 06cee26 to 4d9e8b9 Compare August 24, 2022 12:19
@marler8997
Copy link
Owner

Looks like goto-bus-stop/setup-zig only downloads x86_64 binaries which I think is why the AARCH64 CI's are failing. I'm going to see if I can get that fixed.

@xEgoist
Copy link
Contributor Author

xEgoist commented Aug 25, 2022

Looks like goto-bus-stop/setup-zig only downloads x86_64 binaries which I think is why the AARCH64 CI's are failing. I'm going to see if I can get that fixed.

I could be misinterpreting this but I don't think that would be necessary. Github CI doesn't provide any aarch64 hardware runners. So I think downloading the zig's aarch64 binaries through setup-zig would not help as the runners would not be able to run it or run the tests.

So i believe the only option beside switching to a different CI platform is to test on x86_64 builds and only execute zig build on the other platforms [aarch64]

@marler8997
Copy link
Owner

I see I was mistakenly thinking github was able to run on arm hardware. I've modified the CI to build all targets on all 3 ci hosts. Each os also uploads their aarch64 variant. I tested the macos one on my m1 laptop and it seems to work.

@marler8997 marler8997 merged commit bc2ed0e into marler8997:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ability to specify arch
2 participants