Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was curious about these CRAN check failures:
https://cran.r-project.org/web/checks/check_results_mop.html
The CRAN warnings were caused by
ˆ
instead of^
in theNAMESPACE
file.When I fixed that character in
mop_distance.R
and re-randevtools::document()
to regenerate theNAMESPACE
file, it fixed the first issue. However, because the regular expression now worked inexportPattern()
, two undocumented helper functions were picked up by the permissive regex and added to theNAMESPACE
file under exports, which in turn threw warnings indevtools::check
because those two functions were not documented. I assume these two helpers were not intended to be documented or exported, so I just deleted theexportPattern()
call frommop_distance.R
, which resolved all of this.The newest version of Roxygen2 also required a change to how the overall package was documented:
r-lib/roxygen2#1491