Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deeply changes the way view titles are handled. Functions are not accepted anymore by
View.title()
- only strings. But, and "that is a big but", the string is interpreted as a template, and has access to the raw entry. That allows to customize the view title as follows:In addition, the default view titles are now better. For instance, for an
Entity('posts')
:I had to add inflection to handle singularization/pluralization. It's a good library, and I believe we will use it on other places (first, to remove default field label camel case).
I also chose to remove
Entity.addMappedField()
, and to add all non-mapped properties of the rawEntry from the response to the Entry by default. This removes a big WTF effect I had when trying to customize the deletionView title, and has no side effects.Lastly, to allow the view title to support both a template and a default template, I updated the
Compile
directive to make it transclusive. This was a prerequisite for #118, so it goes in the right direction.Closes #141.