Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create react native project and add precommit for linting purpose #1

Merged
merged 4 commits into from
Feb 15, 2021

Conversation

Clebiez
Copy link
Contributor

@Clebiez Clebiez commented Feb 15, 2021

Description

Initialize React native project and adding Prettier & pre-commit configuration.

ToDo list:

  • Write Readme.md
  • Add makefile commands
  • Init react-native project and run it into browser
  • Add pre-commit hook to be sure every files has been correctly formatted (using husky)
    Husky in V5 doesn't create properly git hooks folder, see issue, that's why I fixed the version to V4

image

README.md Outdated

![Travis (.com)](https://img.shields.io/travis/com/marmelab/foss-starter-kit.svg) ![GitHub top language](https://img.shields.io/github/languages/top/marmelab/foss-starter-kit.svg) ![GitHub contributors](https://img.shields.io/github/contributors/marmelab/foss-starter-kit.svg) ![foss-starter-kit.svg](https://img.shields.io/github/license/marmelab/foss-starter-kit.svg) ![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg)
![Github Actions status](https://github.com/marmelab/pentaog-react-native/workflows/test/badge.svg)![GitHub top language](https://img.shields.io/github/languages/top/marmelab/foss-starter-kit.svg) ![GitHub contributors](https://img.shields.io/github/contributors/marmelab/foss-starter-kit.svg) ![foss-starter-kit.svg](https://img.shields.io/github/license/marmelab/foss-starter-kit.svg) ![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some badge urls pointing to the foss-starter-kit

README.md Outdated
@@ -30,50 +36,50 @@ To learn more about the contributions to this project, consult the [contribution

## Maintainer

[![alexisjanvier](https://avatars1.githubusercontent.com/u/547706?s=96&v=4)](https://github.com/alexisjanvier)
[Alexis Janvier](https://github.com/alexisjanvier)
[![alexisjanvier](https://avatars1.githubusercontent.com/u/547706?s=96&v=4)](https://github.com/alexisjanvier)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to delete all these profiles and add your own ;)

README.md Outdated
[![JulienMattiussi](https://avatars2.githubusercontent.com/u/39904906?s=96&v=4)](https://github.com/JulienMattiussi) | [![Kmaschta](https://avatars2.githubusercontent.com/u/1819833?s=96&v=4)](https://github.com/Kmaschta) | [![Luwangel](https://avatars2.githubusercontent.com/u/5584839?s=96&v=4)](https://github.com/Luwangel)
:---:|:---:|:---:
[JulienM](https://github.com/JulienMattiussi) | [Kmaschta](https://github.com/Kmaschta) | [Adrien Amoros](https://github.com/Luwangel)
| [![JulienMattiussi](https://avatars2.githubusercontent.com/u/39904906?s=96&v=4)](https://github.com/JulienMattiussi) | [![Kmaschta](https://avatars2.githubusercontent.com/u/1819833?s=96&v=4)](https://github.com/Kmaschta) | [![Luwangel](https://avatars2.githubusercontent.com/u/5584839?s=96&v=4)](https://github.com/Luwangel) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to delete the team

@alexisjanvier alexisjanvier merged commit aaccda7 into main Feb 15, 2021
@alexisjanvier alexisjanvier deleted the init-project branch February 15, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants