Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update demo #59

Merged
merged 33 commits into from
Jun 28, 2024
Merged

Update demo #59

merged 33 commits into from
Jun 28, 2024

Conversation

erwanMarmelab
Copy link
Contributor

Problem

React-Admin CRM demo was updated

Solution

Update ra-supabase demo

Base automatically changed from adapt-database-schema-with-demo to main June 10, 2024 05:04
@adguernier adguernier added RFR and removed WIP labels Jun 20, 2024
@slax57 slax57 self-requested a review June 20, 2024 14:17
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions already from reading the code. Now to test the demo.

But this is a huge PR anyways, incredible work! 💪 💪

package.json Outdated Show resolved Hide resolved
packages/demo/.env.local-example Outdated Show resolved Hide resolved
packages/demo/db-seed.ts Outdated Show resolved Hide resolved
packages/demo/src/App.tsx Outdated Show resolved Hide resolved
packages/demo/src/index.tsx Outdated Show resolved Hide resolved
packages/demo/src/misc/NbRelations.tsx Outdated Show resolved Hide resolved
packages/demo/src/notes/NewNote.tsx Outdated Show resolved Hide resolved
packages/demo/src/notes/Note.tsx Show resolved Hide resolved
@slax57
Copy link
Contributor

slax57 commented Jun 21, 2024

Found a couple more issues while testing: 😬

  1. Got the following warning:
Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>.
    at div
    at http://localhost:8000/node_modules/.vite/deps/chunk-ZOST5TTG.js?v=d562344d:4676:51
    at Box3 (http://localhost:8000/node_modules/.vite/deps/chunk-ZOST5TTG.js?v=d562344d:7450:19)
    at LinearProgress (http://localhost:8000/node_modules/.vite/deps/chunk-PXPP5S64.js?v=d562344d:4705:18)
    at ReferenceFieldView (http://localhost:8000/node_modules/.vite/deps/chunk-PXPP5S64.js?v=d562344d:92793:24)
    at ResourceContextProvider (http://localhost:8000/node_modules/.vite/deps/chunk-IT6VC33E.js?v=d562344d:13043:21)
    at NonEmptyReferenceField (http://localhost:8000/node_modules/.vite/deps/chunk-PXPP5S64.js?v=d562344d:92778:23)
    at ReferenceField (http://localhost:8000/node_modules/.vite/deps/chunk-PXPP5S64.js?v=d562344d:92752:22)
    at p
    at http://localhost:8000/node_modules/.vite/deps/chunk-ZOST5TTG.js?v=d562344d:4676:51
    at Typography2 (http://localhost:8000/node_modules/.vite/deps/chunk-UDCJ5W4P.js?v=d562344d:4213:22)
    at div
    at http://localhost:8000/node_modules/.vite/deps/chunk-ZOST5TTG.js?v=d562344d:4676:51
    at ListItemText2 (http://localhost:8000/node_modules/.vite/deps/chunk-UDCJ5W4P.js?v=d562344d:15863:17)
    at a
    at LinkWithRef (http://localhost:8000/node_modules/.vite/deps/chunk-6SAAVCAB.js?v=d562344d:291:5)
    at http://localhost:8000/node_modules/.vite/deps/chunk-ZOST5TTG.js?v=d562344d:4676:51
    at ButtonBase2 (http://localhost:8000/node_modules/.vite/deps/chunk-UDCJ5W4P.js?v=d562344d:3264:17)
    at http://localhost:8000/node_modules/.vite/deps/chunk-ZOST5TTG.js?v=d562344d:4676:51
    at li
    at http://localhost:8000/node_modules/.vite/deps/chunk-ZOST5TTG.js?v=d562344d:4676:51
    at ListItem2 (http://localhost:8000/node_modules/.vite/deps/chunk-UDCJ5W4P.js?v=d562344d:15483:17)
    at RecordContextProvider (http://localhost:8000/node_modules/.vite/deps/chunk-IT6VC33E.js?v=d562344d:6251:21)
    at ul
    at http://localhost:8000/node_modules/.vite/deps/chunk-ZOST5TTG.js?v=d562344d:4676:51
    at List2 (http://localhost:8000/node_modules/.vite/deps/chunk-UDCJ5W4P.js?v=d562344d:15046:17)
    at ContactListContent (
  1. In ContactList filter, got the following error
column contacts.q does not exist
  1. In ContactCreate, when selecting a company, if I type something in the field I get the following error:
    400 Bad Request
    http://localhost:54321/rest/v1/companies?offset=0&limit=25&q=eq.cc&order=id.desc
"message": "column companies.q does not exist"
  1. In ContactNoteCreate
    The status input does not have a default value nor validation, but it is required according to supabase
    Also, we get the following warning in the console:
Warning: A component is changing an uncontrolled input to be controlled.
  1. After adding a contact to a company, when returning to the company page, we can see
    last activity about 2 hours ago
    although the contact was just added.
    There may be an issue regarding the dates management.

  2. CompanyShow does not include Contacts and Deals tabs.
    company.nb_contacts and company.nb_deals appear to be missing in database.

  3. CompanyList filter throws an error.

  4. Adding a new deal_note triggers a call to update the deal that ends up in error:

Column 'last_seen' of relation 'deals' does not exist
  1. DealList filter only filters on Deal name. It should do a full text search instead.

@slax57
Copy link
Contributor

slax57 commented Jun 28, 2024

All issues found in the demo should be fixed now! ✅

Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@slax57 slax57 added this to the 3.0.0 milestone Jun 28, 2024
@slax57 slax57 merged commit f1a62b5 into main Jun 28, 2024
5 checks passed
@slax57 slax57 deleted the update-demo branch June 28, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants