Merge pull request #6357 from marmelab/revert-update-window-title

Revert Update window title on page change

docs/CreateEdit.md

@@ -147,15 +147,6 @@ export const PostEdit = (props) => (
 );
 ```
 
-React Admin also updates the page title based on this `title` prop, as long as it's a string. If you're passing an element as `title`, like in the example above, you have to update the page title yourself. React-admin exports a hook called `useDocumentTitle` to make this simple:
-
-```jsx
-const PostTitle = ({ record }) => {
-    useDocumentTitle(record ?? record.title);
-    return <span>Post {record ? `"${record.title}"` : ''}</span>;
-};
-```
-
 ### Actions
 
 You can replace the list of default actions by your own element using the `actions` prop:

docs/Reference.md

@@ -157,7 +157,6 @@ title: "Reference"
 * [`useDataProvider`](./Actions.md#usedataprovider-hook)
 * [`useDelete`](./Actions.md#usedelete)
 * [`useDeleteMany`](./Actions.md#usedeletemany)
-* `useDocumentTitle`
 * [`useEditController`](./CreateEdit.md#useeditcontroller)
 * `useFilterState`
 * [`useGetIdentity`](./Authentication.md#usegetidentity-hook)

examples/simple/src/posts/PostTitle.tsx

@@ -1,11 +1,13 @@
 import * as React from 'react';
-import { useTranslate, TitleProps, useDocumentTitle } from 'react-admin';
+import { useTranslate, TitleProps } from 'react-admin';
 
 export default ({ record }: TitleProps) => {
     const translate = useTranslate();
-    const title = translate('post.edit.title', { title: record?.title ?? '' });
-
-    useDocumentTitle(title);
-
-    return <span>{record ? title : ''}</span>;
+    return (
+        <span>
+            {record
+                ? translate('post.edit.title', { title: record.title })
+                : ''}
+        </span>
+    );
 };

examples/simple/src/tags/TagEdit.tsx

@@ -32,7 +32,7 @@ const TagEdit = props => (
                 basePath="/posts"
                 resource="posts"
                 filter={{ tags: [props.id] }}
-                title={false}
+                title=" "
             >
                 <Datagrid>
                     <TextField source="id" />

packages/ra-core/src/util/index.ts

@@ -12,7 +12,6 @@ import warning from './warning';
 import useWhyDidYouUpdate from './useWhyDidYouUpdate';
 import { useSafeSetState, useTimeout } from './hooks';
 import { getMutationMode } from './getMutationMode';
-export * from './useDocumentTitle';
 export * from './indexById';
 
 export {

packages/ra-ui-materialui/src/layout/Title.tsx

@@ -3,13 +3,12 @@ import { FC, cloneElement, ReactElement } from 'react';
 import { createPortal } from 'react-dom';
 import PropTypes from 'prop-types';
 import { useTranslate, Record, warning } from 'ra-core';
-import { TitleText } from './TitleText';
 
 export interface TitleProps {
     className?: string;
     defaultTitle?: string;
     record?: Record;
-    title?: string | ReactElement | false;
+    title?: string | ReactElement;
 }
 
 const Title: FC<TitleProps> = ({
@@ -27,18 +26,16 @@ const Title: FC<TitleProps> = ({
 
     if (!container) return null;
 
-    if (typeof title === 'boolean' && !title) return null;
-
     warning(!defaultTitle && !title, 'Missing title prop in <Title> element');
 
     const titleElement = !title ? (
-        <TitleText className={className} {...rest} text={defaultTitle} />
+        <span className={className} {...rest}>
+            {defaultTitle}
+        </span>
     ) : typeof title === 'string' ? (
-        <TitleText
-            className={className}
-            {...rest}
-            text={translate(title, { _: title })}
-        />
+        <span className={className} {...rest}>
+            {translate(title, { _: title })}
+        </span>
     ) : (
         cloneElement(title, { className, record, ...rest })
     );
@@ -48,14 +45,12 @@ const Title: FC<TitleProps> = ({
 export const TitlePropType = PropTypes.oneOfType([
     PropTypes.string,
     PropTypes.element,
-    PropTypes.bool,
 ]);
 
 Title.propTypes = {
     defaultTitle: PropTypes.string,
     className: PropTypes.string,
     record: PropTypes.any,
-    // @ts-ignore
     title: TitlePropType,
 };
 

packages/ra-ui-materialui/src/layout/index.ts

@@ -21,7 +21,6 @@ import Title, { TitleProps, TitlePropType } from './Title';
 import TitleForRecord from './TitleForRecord';
 import TopToolbar from './TopToolbar';
 import UserMenu, { UserMenuProps } from './UserMenu';
-export * from './TitleText';
 
 export {
     AppBar,

packages/ra-ui-materialui/src/types.ts

@@ -28,7 +28,7 @@ export interface ListProps extends ResourceComponentProps {
     perPage?: number;
     sort?: SortPayload;
     syncWithLocation?: boolean;
-    title?: string | ReactElement | false;
+    title?: string | ReactElement;
 }
 
 export interface EditProps extends ResourceComponentPropsWithId {
@@ -43,7 +43,7 @@ export interface EditProps extends ResourceComponentPropsWithId {
     onSuccess?: OnSuccess;
     onFailure?: OnFailure;
     transform?: (data: RaRecord) => RaRecord | Promise<RaRecord>;
-    title?: string | ReactElement | false;
+    title?: string | ReactElement;
 }
 
 export interface CreateProps extends ResourceComponentProps {
@@ -56,7 +56,7 @@ export interface CreateProps extends ResourceComponentProps {
     onSuccess?: OnSuccess;
     onFailure?: OnFailure;
     transform?: (data: RaRecord) => RaRecord | Promise<RaRecord>;
-    title?: string | ReactElement | false;
+    title?: string | ReactElement;
 }
 
 export interface ShowProps extends ResourceComponentPropsWithId {
@@ -65,7 +65,7 @@ export interface ShowProps extends ResourceComponentPropsWithId {
     classes?: any;
     className?: string;
     component?: ElementType;
-    title?: string | ReactElement | false;
+    title?: string | ReactElement;
 }
 
 export interface BulkActionProps {