Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use SimpleList whitin edit form #2462

Closed
vedmalex opened this issue Oct 23, 2018 · 3 comments
Closed

Can't use SimpleList whitin edit form #2462

vedmalex opened this issue Oct 23, 2018 · 3 comments
Assignees
Labels

Comments

@vedmalex
Copy link
Contributor

vedmalex commented Oct 23, 2018

i've use with Responsive component for xsmall size SimpleList
as for react-admin 2.1 it is works fine but for 2.4 it is broken
i've reproduced the sample scenario for that bug

the same applied for show and edit-form

just select any post with comments and go to the comment it wil not display any, while for 2.1 for the original sample it is working

sample project

@vedmalex vedmalex changed the title Can't use Simple list whit in edit form Can't use SimpleList whit in edit form Oct 23, 2018
@vedmalex vedmalex changed the title Can't use SimpleList whit in edit form Can't use SimpleList whitin edit form Oct 23, 2018
@despatates
Copy link
Contributor

I experimented the same issue with <SimpleList /> when set as child of <ReferenceManyField /> (was working before v2.2.0).
No total or isLoading props are provided by ReferenceManyField, so no result is displayed.

Your fix should fix this use case too.

@fzaninotto
Copy link
Member

Confirmed and reproduced

@fzaninotto
Copy link
Member

Incidentally, this is the type of regression that a strong set of types would prevent...

mikaoelitiana pushed a commit to mikaoelitiana/react-admin that referenced this issue Nov 22, 2018
mikaoelitiana pushed a commit to mikaoelitiana/react-admin that referenced this issue Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants