Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inputs throw error when passing react-final-form props #5288

Closed
WiXSL opened this issue Sep 22, 2020 · 1 comment · Fixed by #5300
Closed

Inputs throw error when passing react-final-form props #5288

WiXSL opened this issue Sep 22, 2020 · 1 comment · Fixed by #5300
Assignees
@fzaninotto
Labels
bug good first issue

Comments

@WiXSL
Copy link
Contributor

WiXSL commented Sep 22, 2020 •
edited
Loading

Some of react-final-form FieldProps props are not sanitized in react-admin inputs.
For example:

<BooleanInput
     allowEmpty
     label="Can edit?"
     source="canEdit"
     beforeSubmit={() => false} // <-- Throws error
/>
  • React-admin version: 3.8.5
  • React version: 16.13.1
  • Browser: Chrome
@djhi
Copy link
Collaborator

djhi commented Sep 24, 2020

Thanks for reporting

@fzaninotto fzaninotto self-assigned this Sep 24, 2020
fzaninotto added a commit that referenced this issue Sep 24, 2020
@fzaninotto
Fix warning when passing FieldProps to Input components
d2f8b74 
Closes #5288
@fzaninotto fzaninotto mentioned this issue Sep 24, 2020
Merged
gavacho pushed a commit to gavacho/react-admin that referenced this issue Sep 27, 2020
@fzaninotto
Fix warning when passing FieldProps to Input components
541b7e4 
Closes marmelab#5288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fzaninotto fzaninotto

Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix warning when passing FieldProps to Input components marmelab/react-admin
3 participants
@fzaninotto @djhi @WiXSL