Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow MenuItemLink to have a customizable and optional tooltip #5359

Closed
gstn-caruso opened this issue Oct 6, 2020 · 1 comment
Closed

Allow MenuItemLink to have a customizable and optional tooltip #5359

gstn-caruso opened this issue Oct 6, 2020 · 1 comment

Comments

@gstn-caruso
Copy link

gstn-caruso commented Oct 6, 2020

Problem description
I added a few MenuItemLinks in my Customized Appbar but then I wanted to customized the tooltips (I don't want them or I want to change the content), it turns that the configuration for that component was hardcoded to display the same than the primary title and to be displayed on the right side.

The solution I'd like
I would like to be able to pass the props to the MenuItemLink with the tooltip options, and if I don't pass any, I don't want the tooltip to be rendered.

Alternatives I've considered
I've considered using another component apart from the MenuItemLink, but this component is configured out of the box to keep track of the current route.

Here is a PR

@fzaninotto
Copy link
Member

Fixed by #5714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants