Allow MenuItemLink to receive TooltipPops #5360
Conversation
There was a problem hiding this comment.
Looks good. However, we'd like the tooltip to be displayed by default as before (using the primaryText).
Can you please update the PR so that you can disable the tooltip by passing false a new tooltip prop? This prop should accept a label and defaults to the primaryText if undefined.
|
I don't think that disabling tooltip is a good feature. When the sidebar is closed, users need the tooltip. So please limit your PR to allowing custom tooltip props, not removing the tooltip. |
|
Sure, let me change that 👌. Apart from that change I have a question @fzaninotto, is this element supposed to be used only in the sidebar? I tried to put it in a custom Appbar (that's why I wanted to remove the tooltip, or at least customize it) |
|
Ys, it's only designed to be used in the Sidebar |
|
Any updates on this one? |
Closes #5359